Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(modem): More error handling in cmux protocol #362

Merged
merged 2 commits into from
Sep 25, 2023

Conversation

david-cermak
Copy link
Collaborator

Add error path to all CMUX protocol potential issues, checks for consistency and add recovery.

@david-cermak david-cermak self-assigned this Sep 20, 2023
Add error path to all CMUX protocol potential issues, checks for
consistency and add recovery.
Loopback terminal uses std::async to inject test data to the test
terminal. There was a hazardeous condition when destructing the terminal
while async batch_read() was in progress. Adding a signal and waiting
for destruction solves the issue.
@david-cermak david-cermak merged commit 19baa7d into espressif:master Sep 25, 2023
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants